Skip to content

Conversation

ImadSaddik
Copy link
Contributor

In the documentation's description section, there is a link or reference to the "request body" within a paragraph. However, when users click on this link, it fails to redirect them to the intended "request body" section of the document.

I was just reading the search API and I found this issue, it should be a quick fix.

pmpailis and others added 30 commits August 7, 2024 23:20
…#111595)

Ocassionally we see a LISTING.TXT not included in the jar. The cause
seems a timing issue with sync task were target root folder is same
folder as folder containing listing.txt.
…lastic#111725) (elastic#111728)

The `java.security.manager=allow` system property is required when
running tests on newer Java versions with the security manager
deprecated. As such, it should be set in our
`GradleTestPolicySetupPlugin` so that it's done for external plugin
authors.
…elastic#111475) (elastic#111735)

Fix validation of fields mapped to different types in different indices and align with validation of fields of unsupported type.

* Allow using multi-typed fields in KEEP and DROP, just like unsupported fields.
* Explicitly invalidate using both these field kinds in RENAME.
* Map both kinds of fields to UnsupportedAttribute to enforce consistency.
* Consider convert functions containing valid multi-typed fields as resolved to avoid weird workarounds when resolving STATS.
* Add a bunch of tests.

(cherry picked from commit 585480f)

# Conflicts:
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/union_types.csv-spec
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/Stats.java
…elastic#111646)

* Move DeleteInferenceAction pipeline check to utility threadpool

* Update docs/changelog/111646.yaml

* Update docs/changelog/111646.yaml

Co-authored-by: David Kyle <[email protected]>

---------

Co-authored-by: David Kyle <[email protected]>
…astic#111759)

Fix elastic#111753

(cherry picked from commit f0d06ee)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
elastic#111761)

This reverts elastic#110261 which we can't land until elastic#111757 - we need to be
sure that the `equals` implementations on subclasses of
`InternalAggregations` is correct before this optimization is safe.

Closes elastic#111679
…without dims (elastic#111756) (elastic#111763)

* Fix NullPointerException when doing knn search on empty index without dims (elastic#111756)

* Fix NullPointerException when doing knn search on empty index without dims

* Update docs/changelog/111756.yaml

* Fix typo in yaml test

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 4e26114)

# Conflicts:
#	rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/40_knn_search.yml

* Update 40_knn_search.yml

* Yaml
This change ensures that we don't try to compute stats on mappings that don't have dense or sparse vector fields. We don't need to go through all the fields on every segment, instead we can extract the vector fields upfront and limit the work to only indices that define these types.

Closes elastic#111715
Since apache/lucene-solr#620, intervals disjunctions are automatically rewritten to handle cases where minimizations can miss valid matches.
This change updates the documentation to take this behaviour into account (users don't need to manually pull intervals disjunctions to the top anymore).
…11825)

Spells out some cases in which ILM doesn't delete the underlying
searchable snapshot and instructs users to delete them manually instead.

Co-authored-by: shainaraskas <[email protected]>
…c#111849)

* Add maximum nested depth check to WKT parser

This prevents StackOverflowErrors, replacing them with ParseException errors, which is more easily managed by running servers.

* Update docs/changelog/111843.yaml
Clarify that it's best to analyse the captures alongside the node logs,
and spell out in a bit more detail how to use packet captures and logs
to pin down the cause of a `disconnected` node.
…cumentation (elastic#111833) (elastic#111869)

* Fixed the description of 'affected_resources' in health API documentation

* Update docs/reference/health/health.asciidoc



---------

Co-authored-by: István Zoltán Szabó <[email protected]>
not-napoleon and others added 20 commits October 5, 2024 00:55
…astic#113961) (elastic#114138)

While working on Date Nanos, I noticed that Least and Greatest didn't have support for datetime. This PR corrects that and adds tests for it.

It seems to me that resolveType() is doing the wrong thing for these functions, as it accepts types that then do not have evaluator mappings, but refactoring that seems out of scope right now.

---------

Co-authored-by: Elastic Machine <[email protected]>
Today there are a handful of integer settings for `repository-s3`
repositories whose docs link to the page about numeric field types. Yet
these settings are not fields, and do not support floating-point values
either. The convention throughout the rest of the docs is to just call
these things `integer` without linking to anything. This commit aligns
the `repository-s3` docs with this convention.

Backport of elastic#114093 to `8.15`
…elastic#114197)

* Fix BWC for file-settings based role mappings (elastic#113900)

* Fix BWC for file settings based role mappings
---------

Co-authored-by: Johannes Freden Jansson <[email protected]>
(cherry picked from commit 763764c)

# Conflicts:
#	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/action/rolemapping/TransportDeleteRoleMappingAction.java
#	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/action/rolemapping/TransportPutRoleMappingAction.java
#	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/support/mapper/ClusterStateRoleMapper.java

* fixup! Inconsistent API with 9.x

---------

Co-authored-by: Nikolaj Volgushev <[email protected]>
Spells out that third-party EOL schedules don't affect our support. Also
reorders the information to talk about the benefits of the bundled JDK
before mentioning alternatives, and clarifies the division of
responsibilities for "supported" JDKs other than the bundled one.
…lastic#114217)

This example request will succeed, but follow-up requests to run a sync on a connector with this language value will fail.
…elastic#114222)

This changes the suffix for a role mapping to be `-read-only` instead of
` (read only)` since the name can be used (and will be by Kibana) to get
a specific operator defined role mapping.

This also removes the suffix when checking cluster state for the
mapping. There is a slight risk that `<name>-read-only` exists both in
the native store and as `<name>` in the file based mapping. I think
that's very low risk, so didn't add any code to cover that case.

(cherry picked from commit bc8f9dc)

# Conflicts:
#	x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/action/role/TransportDeleteRoleAction.java
… (elastic#114274)

Today the docs for the `?wait_for_active_shards` parameter say that it
must be a positive integer, proscribing `0`, yet `0` is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.
…ic#114338)

* Docs: ESQL doesn't preserve `null`s in a list (elastic#114335)

The doc values don't preserve `null`s in a list so ESQL doesn't either.

Closes elastic#114324

* Update
…is empty (elastic#114264) (elastic#114355)

This change fixes analyzed wildcard query in simple_query_string when disjunctions is empty.

Closes elastic#114185

(cherry picked from commit 6955bc1)

Co-authored-by: Halil Bülent Orhon <[email protected]>
…#113900)" and related  (elastic#114326) (elastic#114405)

# Backport

This will backport the following commits from `main` to `8.15`:
 - [Revert &quot;Fix BWC for file-settings based role mappings (elastic#113900)&quot; and related  (elastic#114326)](elastic#114326)
…stic#114421)

This (backport) PR default-enables cluster-state role mappings as the first part of the mitigation for a regression in ECK introduced by elastic#107410. 

Prior to this PR, cluster-state role mappings were written to cluster-state, but not read from it. 

With this PR, cluster-state role mappings will be read and used to assign roles to users, i.e. in user role resolution. 

However, they will not be included in the output of the [Get role mappings API](https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-get-role-mapping.html) yet. Exposing them via API is a target for a follow-up fix.

Relates: ES-9628
Supersedes: elastic#113900
…ic#114430) (elastic#114435)

this workarounds an issue we currently see on windows ci boxes where we
run into timeouts in this step in our builds
)

A silly bug has reared its ugly head. Apparently, our dimension
validations are predicated on JSON parsing order, that is not good.

So, this commit adjusts the dim validations so that it is an actual
validation, instead of something that occurs during parsing.

Additionally, I found that our custom formats were not overriding
`getMaxDimensions` correctly. Typically, and in production, this isn't
that big of a deal, but I have found it useful to do this for other
testing purposes (so that we don't have to rely on the perfield codec
for more direct and advanced testing).

(cherry picked from commit 7942f3e)
`MV_SLICE` is useful, but loading values from lucene frequently sorts
them so `MV_SLICE` is not as useful as you think it is. It's mostly for
after, say, a `SPLIT`. This documents that and adds a link to the
section on multivalues.

It also moves similar docs to a separate paragraph in the docs for
easier reading.
In the description section, when clicking on request body in the paragraph, we don't get redirected to the corresponding section.
@ImadSaddik ImadSaddik requested review from a team as code owners October 18, 2024 21:51
Copy link
Contributor

Documentation preview:

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
7576ff0,

Please, read and sign the above mentioned agreement if you want to contribute to this project

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v9.0.0 labels Oct 18, 2024
@ImadSaddik ImadSaddik closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.